SAP Spartacus deprecation for 4.0 需要注意的一些事项
this is not official way, but we practise grupping items in variables definition
export const ITEM_SERVICE = ‘ItemService’; - this is part of organization, it can be close to organization variables
更新文檔:\docs\migration\4_0.md
ToggleStatusComponent
- Removed FeatureConfigService from constructor.
DeleteItemComponent
- Removed FeatureConfigService from constructor.
deprecatedParams should contain parameter to remove
the meaning of “deprecatedParams”: this block should contain all the parameters used in deprecated constructors( I mean the deleted constructor )?
it is like “old constructor”.
其他同事完成修改后,git pull origin epic/organization-deprecations to update your branch
一個潛在的 conflict 問題
we define all migration related constants centrally in file: projects\schematics\src\shared\constants.ts
Suppose both colleague A and B are working on different Component,which have same parameter in constructor signature, let’s say ItemService.
Since A and B are working in parallel, both declared ITEM_SERVICE = ‘ItemService’ in their local constants.ts.
and A push his change first. But B wasn’t aware of A’s work. When B tries to merge his PR, B will find there’s some conflict. And B has to manually resolve the conflict. Do I understand correctly?
答案
you can have 2 kinds of conflict like:
git recognized that both developers changed the same lines, and you must resolve it manually by choosing version (or both)
both people added the same variable in the same file, but in different places so git will not see any problem, but your IDE (eslint) should.
create own branch based on epic/organization-deprecations
so you create an own branch fix/GH-11530, and wants to merge commit into epic/organization-deprecations.
創(chuàng)作挑戰(zhàn)賽新人創(chuàng)作獎勵來咯,堅持創(chuàng)作打卡瓜分現(xiàn)金大獎總結
以上是生活随笔為你收集整理的SAP Spartacus deprecation for 4.0 需要注意的一些事项的全部內容,希望文章能夠幫你解決所遇到的問題。
- 上一篇: 夜未央
- 下一篇: 苏轼的故事 励志故事三则